Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Jetty 8.0 groovy to java #7975

Merged
merged 23 commits into from
Mar 11, 2023
Merged

Convert Jetty 8.0 groovy to java #7975

merged 23 commits into from
Mar 11, 2023

Conversation

heyams
Copy link
Contributor

@heyams heyams commented Mar 4, 2023 •
edited
Loading

related to #7195

@heyams heyams changed the title Convert jedis 8.0 groovy to java Convert Jetty 8.0 groovy to java Mar 4, 2023
@heyams
Copy link
Contributor Author

heyams commented Mar 7, 2023

does anyone know how to resolve 'Unable to load class 'Io_opentelemetry_instrumentation_muzzleGenerationPlugin'."?
i followed troubleshooting guide, same outcome though.

@mateuszrzeszutek
Copy link
Member

does anyone know how to resolve 'Unable to load class 'Io_opentelemetry_instrumentation_muzzleGenerationPlugin'."? i followed troubleshooting guide, same outcome though.

When does that happen?
Just to make sure -- in the last few days we've updated gradle version to 8.0, can you merge/rebase with main and try again?

@heyams
Copy link
Contributor Author

heyams commented Mar 8, 2023

does anyone know how to resolve 'Unable to load class 'Io_opentelemetry_instrumentation_muzzleGenerationPlugin'."? i followed troubleshooting guide, same outcome though.

When does that happen? Just to make sure -- in the last few days we've updated gradle version to 8.0, can you merge/rebase with main and try again?

It was auto resolved after I reboot my machine. Somehow my IntelliJ was in a weird state and messed up gradle. Thanks.

@heyams heyams marked this pull request as ready for review March 8, 2023 17:25
@heyams heyams requested a review from a team March 8, 2023 17:25
mateuszrzeszutek
mateuszrzeszutek reviewed Mar 9, 2023
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help @heyams !

...nt/src/test/java/io/opentelemetry/javaagent/instrumentation/jetty/v8_0/JettyHandlerTest.java Outdated Show resolved Hide resolved
...nt/src/test/java/io/opentelemetry/javaagent/instrumentation/jetty/v8_0/JettyHandlerTest.java Outdated Show resolved Hide resolved
...nt/src/test/java/io/opentelemetry/javaagent/instrumentation/jetty/v8_0/JettyHandlerTest.java Show resolved Hide resolved
@heyams heyams requested a review from mateuszrzeszutek March 9, 2023 19:45
@laurit laurit merged commit 468aa9e into open-telemetry:main Mar 11, 2023
@laurit laurit mentioned this pull request Mar 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@laurit laurit laurit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heyams @mateuszrzeszutek @laurit