feat(opentelemetry-sampler-aws-xray): Add Rate Limiter and Sampling Targets Poller Logic #2924
Conversation
…argets Poller Logic
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2924 +/- ##
=======================================
Coverage 89.06% 89.06%
=======================================
Files 188 188
Lines 9219 9219
Branches 1900 1900
=======================================
Hits 8211 8211
Misses 1008 1008 🚀 New features to boost your workflow:
|
|
|
||
| import { SamplingRuleApplier } from './sampling-rule-applier'; | ||
| import { PACKAGE_NAME } from './version'; |
There was a problem hiding this comment.
How this file is generated? I tried 'npm run setup:dev' and 'npm run compile', none of them generate this file and that is causing build failure.
There was a problem hiding this comment.
It is generated by npm run version:update. However, while this package is in the incubator folder, this command isn't automatically run for this package until it is moved out of this directory.
incubator/opentelemetry-sampler-aws-xray/src/fallback-sampler.ts
Outdated
Show resolved
Hide resolved
incubator/opentelemetry-sampler-aws-xray/test/fallback-sampler.test.ts
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public toString(): string { | ||
| return `RateLimitingSampler{rate limiting sampling with sampling config of ${this.quota} req/sec and 0% of additional requests}`; |
There was a problem hiding this comment.
nit: do we need 'and 0% of additional requests' in the context of rate limiting?
There was a problem hiding this comment.
No, but I kept this text to be aligned with the Python implementation.
incubator/opentelemetry-sampler-aws-xray/src/aws-xray-sampling-client.ts
Outdated
Show resolved
Hide resolved
|
@dyladan Yes, Luke is from AWS, and he can be considered as an SME for this PR. Will be addressing his comments soon. |
Which problem is this PR solving?
Short description of the changes
This PR is a followup to #2824
SamplingRuleApplier.SamplingRuleApplierwill sample the requests.GetSamplingTargetscall to determine the next targetRateLimitingSampler(applied before the fixed rate sampler) to be used in each rule applier.FallbackSampleris updated to be a combination of above samplers to sample1 req/secand5%of additional requests in that second.This PR's implementation was tested against X-Ray's Centralized Sampling Integration tests.