-
Notifications
You must be signed in to change notification settings - Fork 586
feat(kafkajs): instrument transaction send and sendBatch #2939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adbista
wants to merge
7
commits into
open-telemetry:main
Choose a base branch
from
adbista:feat/instrumentation-kafkajs/transaction-send-batch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(kafkajs): instrument transaction send and sendBatch #2939
adbista
wants to merge
7
commits into
open-telemetry:main
from
adbista:feat/instrumentation-kafkajs/transaction-send-batch
+786
−199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wrap transaction send and sendBatch methods
…nsaction span, rename assert helper, and improve test structure
…ds for transaction methods
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2939 +/- ##
==========================================
+ Coverage 89.02% 89.10% +0.07%
==========================================
Files 188 188
Lines 9223 9271 +48
Branches 1900 1901 +1
==========================================
+ Hits 8211 8261 +50
+ Misses 1012 1010 -2
🚀 New features to boost your workflow:
|
seemk
reviewed
Jul 22, 2025
…span OK on successful commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
sendBatch
orsend
methods if they are being called during KafkaJs transaction (e.g.producer.transaction().sendBatch()
) #2741Short description of the changes