Skip to content

feat(kafkajs): instrument transaction send and sendBatch #2939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

adbista
Copy link

@adbista adbista commented Jul 16, 2025

Which problem is this PR solving?

Short description of the changes

  • Instruments transaction.send and sendBatch with proper parent span (transactionSpan), which is ended on commit or abort

@adbista adbista requested a review from a team as a code owner July 16, 2025 13:45
Copy link

linux-foundation-easycla bot commented Jul 16, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 98.11321% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.10%. Comparing base (de22600) to head (74ac115).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ges/instrumentation-kafkajs/src/instrumentation.ts 98.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2939      +/-   ##
==========================================
+ Coverage   89.02%   89.10%   +0.07%     
==========================================
  Files         188      188              
  Lines        9223     9271      +48     
  Branches     1900     1901       +1     
==========================================
+ Hits         8211     8261      +50     
+ Misses       1012     1010       -2     
Files with missing lines Coverage Δ
...ges/instrumentation-kafkajs/src/instrumentation.ts 97.63% <98.11%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adbista adbista requested a review from seemk July 22, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants