fix: enable programmatic config when environment variables are unset #2947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
OTEL_NODE_ENABLED_INSTRUMENTATIONS
is not set, users cannot enable default-excluded instrumentations (likefs
) through programmatic configuration.getNodeAutoInstrumentations({"@opentelemetry/instrumentation-fs": {enabled: true}})
didn't work when environment variables were not configured.Short description of the changes
Configuration Priority (after changes):
OTEL_NODE_DISABLED_INSTRUMENTATIONS
- absolute priorityOTEL_NODE_ENABLED_INSTRUMENTATIONS
- when set, only enable listed instrumentationsuserConfig.enabled
) - when env vars are unsetdefaultExcludedInstrumentations
unless explicitly enabled