Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

honor initial set zap loglevel #1603

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

prolane
Copy link

@prolane prolane commented Nov 21, 2024

os.Getenv("OPENTELEMETRY_EXTENSION_LOG_LEVEL") returns an empty string when the env var is not set. zap.ParseAtomicLevel("") will return info log level.

This means line lvl := zap.NewAtomicLevelAt(zapcore.InfoLevel) is never used.
This PR fixes this.

@prolane prolane requested a review from a team as a code owner November 21, 2024 10:58
Copy link

linux-foundation-easycla bot commented Nov 21, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@pragmaticivan
Copy link
Contributor

The code LGTM. It indeed fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants