chore: update collector dependency #1757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @theSuess, can you check the failing tests? |
|
Seems like I missed a few submodules and |
theSuess
force-pushed
the
chore/update-collector-dependencies
branch
5 times, most recently
from
0e5ca1f to
ce0d7a6
Compare
|
@serkan-ozal All tests are passing now! |
tylerbenson
reviewed
Apr 10, 2025
tylerbenson
approved these changes
Apr 10, 2025
|
Thanks for fixing this! |
theSuess
force-pushed
the
chore/update-collector-dependencies
branch
from
ce0d7a6 to
b94314c
Compare
theSuess
force-pushed
the
chore/update-collector-dependencies
branch
from
b94314c to
eee34de
Compare
serkan-ozal
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the collector dependencies to the latest version. The updates require some code changes, which is why #1737 is failing.
Newer versions of the collector include support for default values when configuring through secretsmanagerprovider which is especially useful for lambdas.