wip: capture spans for controllers automatically #282
Conversation
cedricziel
force-pushed
the
trace-controller
branch
from
a0dfbe3 to
8cd1747
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
============================================
- Coverage 80.83% 80.61% -0.22%
+ Complexity 1502 1457 -45
============================================
Files 128 123 -5
Lines 6183 5871 -312
============================================
- Hits 4998 4733 -265
+ Misses 1185 1138 -47 Flags with carried forward coverage won't be shown. Click here to find out more. see 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| if (\strpos($controllerName, '::') > 0) { | ||
| list($class, $method) = \explode('::', $controllerName); | ||
| if (isset($class, $method)) { | ||
| hook( |
There was a problem hiding this comment.
I don't think this will work with modern runtimes, where one long-lived application might handle many requests.
Maybe it should just manually create and end span on Symfony events?
There was a problem hiding this comment.
I think I'd rather memoize the hooks already in place. - this hook in particular is for the controller callable
cedricziel
force-pushed
the
trace-controller
branch
from
8cd1747 to
9f0c80f
Compare
No description provided.