Skip to content

Conversation

@ZebraNorth
Copy link

Closes #1450

Don't throw an unhandled exception if the file /etc/machine-id cannot be read.

@ZebraNorth ZebraNorth requested a review from a team as a code owner December 11, 2024 19:46
@welcome
Copy link

welcome bot commented Dec 11, 2024

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 11, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.19%. Comparing base (4a021fb) to head (9ad8607).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/SDK/Resource/Detectors/Host.php 75.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1451      +/-   ##
============================================
- Coverage     73.26%   73.19%   -0.07%     
- Complexity     2685     2687       +2     
============================================
  Files           387      387              
  Lines          8009     8011       +2     
============================================
- Hits           5868     5864       -4     
- Misses         2141     2147       +6     
Flag Coverage Δ
8.1 ?
8.2 ?
8.3 ?
8.4 ?
8.5 73.19% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/SDK/Resource/Detectors/Host.php 67.39% <75.00%> (-3.07%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a021fb...9ad8607. Read the comment docs.

@brettmc
Copy link
Contributor

brettmc commented Dec 23, 2024

Closing, replaced by #1454

@brettmc brettmc closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File(/etc/machine-id) is not within the allowed path(s)

2 participants