Skip to content

Fix missing metrics attributes in console exporter #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

Fix missing metrics attributes in console exporter #1558

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
948ab95
Fix missing metrics attributes in console exporter
GrzegorzDrozd Apr 7, 2025
2a60bbe
Fix code review/check style issue
GrzegorzDrozd Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/SDK/Common/Attribute/Attributes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,13 @@

use function array_key_exists;
use IteratorAggregate;
use JsonSerializable;
use Traversable;

/**
* @psalm-suppress MissingTemplateParam
*/
final class Attributes implements AttributesInterface, IteratorAggregate
final class Attributes implements AttributesInterface, IteratorAggregate, JsonSerializable
{
/**
* @internal
Expand Down Expand Up @@ -48,6 +49,11 @@ public function count(): int
return \count($this->attributes);
}

public function jsonSerialize(): mixed
{
return $this->attributes;
}

public function getIterator(): Traversable
{
foreach ($this->attributes as $key => $value) {
Expand Down
Loading