Skip to content

feat(carreirs): implement environment context getter setter #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ycchuang99
Copy link
Contributor

Closes #1566

@ycchuang99 ycchuang99 requested a review from a team as a code owner July 20, 2025 20:37
Copy link

linux-foundation-easycla bot commented Jul 20, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@ycchuang99 ycchuang99 force-pushed the feature/environment-context-propagation branch from 5af6568 to 52e48e9 Compare July 20, 2025 20:39
@ycchuang99 ycchuang99 force-pushed the feature/environment-context-propagation branch from 52e48e9 to 8b2461d Compare July 20, 2025 20:43
Copy link

codecov bot commented Jul 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.75%. Comparing base (2421c64) to head (43009b1).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1668      +/-   ##
============================================
+ Coverage     68.70%   68.75%   +0.04%     
- Complexity     2854     2864      +10     
============================================
  Files           425      426       +1     
  Lines          8699     8716      +17     
============================================
+ Hits           5977     5993      +16     
- Misses         2722     2723       +1     
Flag Coverage Δ
8.1 68.52% <100.00%> (+0.11%) ⬆️
8.2 68.63% <100.00%> (+0.01%) ⬆️
8.3 68.62% <100.00%> (+0.03%) ⬆️
8.4 68.67% <100.00%> (+0.02%) ⬆️
8.5 68.64% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/Context/Propagation/EnvironmentGetterSetter.php 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2421c64...43009b1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

{
protected function tearDown(): void
{
putenv('A');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have OpenTelemetry\Tests\TestState trait to handle setting and cleaning up the environment.

@brettmc
Copy link
Contributor

brettmc commented Jul 21, 2025

How does one use this in conjunction with existing propagators? Could you add an example under the examples dir?

@ycchuang99
Copy link
Contributor Author

How does one use this in conjunction with existing propagators? Could you add an example under the examples dir?

Thanks for the review! Yes, I’ll add an example.

@ycchuang99 ycchuang99 marked this pull request as draft July 23, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[spec 1.44.0] implement environment variable context propagation
2 participants