-
Notifications
You must be signed in to change notification settings - Fork 206
feat(carreirs): implement environment context getter setter #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(carreirs): implement environment context getter setter #1668
Conversation
5af6568
to
52e48e9
Compare
52e48e9
to
8b2461d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1668 +/- ##
============================================
+ Coverage 68.70% 68.75% +0.04%
- Complexity 2854 2864 +10
============================================
Files 425 426 +1
Lines 8699 8716 +17
============================================
+ Hits 5977 5993 +16
- Misses 2722 2723 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
{ | ||
protected function tearDown(): void | ||
{ | ||
putenv('A'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have OpenTelemetry\Tests\TestState
trait to handle setting and cleaning up the environment.
How does one use this in conjunction with existing propagators? Could you add an example under the |
Thanks for the review! Yes, I’ll add an example. |
Closes #1566