update declarative config to 1.0-rc.2 #1733
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* suppress some new psalm complaints * apply x2 rector suggested fixes
- adds service detector - configurator name and config are not required see https://github.com/open-telemetry/opentelemetry-configuration/releases/tag/v1.0.0-rc.1 and https://github.com/open-telemetry/opentelemetry-configuration/releases/tag/v1.0.0-rc.2
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1733 +/- ##
============================================
+ Coverage 68.26% 68.35% +0.08%
- Complexity 2970 2972 +2
============================================
Files 448 449 +1
Lines 9029 8718 -311
============================================
- Hits 6164 5959 -205
+ Misses 2865 2759 -106
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 216 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Nevay
reviewed
Oct 29, 2025
tests/Integration/Config/ComponentProvider/Metrics/MetricExporterPrometheus.php
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@open-telemetry/php-approvers I've addressed review comments, ready for re-review please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/open-telemetry/opentelemetry-configuration/releases/tag/v1.0.0-rc.1 and https://github.com/open-telemetry/opentelemetry-configuration/releases/tag/v1.0.0-rc.2