feat: Implement onEnding interface of Span Processor in Trace SDK #1785
+65
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1785 +/- ##
============================================
- Coverage 68.49% 68.49% -0.01%
- Complexity 2970 2974 +4
============================================
Files 448 448
Lines 8714 8720 +6
============================================
+ Hits 5969 5973 +4
- Misses 2745 2747 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
brettmc
approved these changes
Nov 22, 2025
Nevay
suggested changes
Nov 22, 2025
|
|
||
| $this->endEpochNanos = $endEpochNanos ?? Clock::getDefault()->now(); | ||
| if ($this->spanProcessor instanceof ExtendedSpanProcessorInterface) { | ||
| $this->spanProcessor->onEnding($this); |
Contributor
There was a problem hiding this comment.
Must prevent modifications from outside of the ::onEnding() callbacks.
Should backport the 2.x Span::end() implementation #1483 if we want to add this to 1.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to implement onEnding interface of Span Processor in Trace SDK.
Changes:
Span::end()function