Populate both origin and hostname correctly to span attributes #3097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the hostname was conflated with the origin; however, they are distinct concepts, as detailed in the issue below.
Fixes #3096
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested end-to-end with a demo app available here https://github.com/shivanshuraj1333/celery-opentelemetry-instrumentation
Below are the new attributes in spans and metrics after the change:
Celery host:
Stack Trace Dump from Celery:
Span attributes:
Metrics attributes:
Additional Info:
Celery release notes where origin was introduced first in Celery 4.0 https://docs.celeryq.dev/en/latest/history/whatsnew-4.0.html#whatsnew-4-0
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.