Audit and test opentelemetry-instrumentation-boto #3376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Venkata Shreyas Kabekkodu <[email protected]>
Signed-off-by: Venkata Shreyas Kabekkodu <[email protected]>
Signed-off-by: Venkata Shreyas Kabekkodu <[email protected]>
Signed-off-by: Venkata Shreyas Kabekkodu <[email protected]>
Signed-off-by: Venkata Shreyas Kabekkodu <[email protected]>
Signed-off-by: Venkata Shreyas Kabekkodu <[email protected]>
Signed-off-by: Venkata Shreyas Kabekkodu <[email protected]>
Signed-off-by: Venkata Shreyas Kabekkodu <[email protected]>
Signed-off-by: Venkata Shreyas Kabekkodu <[email protected]>
Signed-off-by: Venkata Shreyas Kabekkodu <[email protected]>
Signed-off-by: Venkata Shreyas Kabekkodu <[email protected]>
itsvshreyas
changed the title
|
Hi @codeboten , Could you please review this PR or help in getting necessary approvals/reviews for this PR? Thanks! |
xrmx
reviewed
Mar 28, 2025
xrmx
reviewed
Mar 28, 2025
| self.assertEqual(len(spans), 0) | ||
|
|
||
|
|
||
| if __name__ == "__main__": |
There was a problem hiding this comment.
We don't need to run tests like this
There was a problem hiding this comment.
We don't need to run tests like this
Okay, I removed it in my new commit as I moved the entire function to the other file.
xrmx
reviewed
Mar 28, 2025
|
|
||
| # Ensure no spans are created | ||
| tracer = get_tracer_provider().get_tracer("test") | ||
| if isinstance(self.noop_tracer_provider, NoOpTracerProvider): |
When you said other file, you meant this right? instrumentation/opentelemetry-instrumentation-boto/tests/test_boto_instrumentation.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An #956 was found in the wsgi instrumentation by integration tests in the core repository. The issue should have been caught by unit tests in the instrumentation using the NoOpTracerProvider.
The outcome of this issue is to ensure each instrumentation contains a test using the NoOpTracerProvider and that it does not rely on the OpenTelemetry SDK. This test is specific to boto.
Fixes #989
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.