fix: grpc server ValueError when using unix sockets #3394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with some grpc implementations the full .peer address is available for unix sockets, which includes the socket path. it seems that in versions of grpc prior to 1.53.0, the full path is returned by `context.peer()`. rather than change the dependency of the instrumentation, this updates it to more gracefully handle the case of the socket path being present or absent. Fixes open-telemetry#3393
|
I suspect grpc/grpc#31108 might have resulted in grpc not returning anything beyond |
xrmx
approved these changes
Mar 31, 2025
|
@diurnalist please add a changelog entry |
done, sorry I missed that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
with some grpc implementations the full .peer address is available for unix sockets, which includes the socket path. it seems that in versions of grpc prior to 1.53.0, the full path is returned by
context.peer(). rather than change the dependency of the instrumentation, this updates it to more gracefully handle the case of the socket path being present or absent.Fixes #3393
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.