-
Notifications
You must be signed in to change notification settings - Fork 847
Drop django 1.10 support #4083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Drop django 1.10 support #4083
Conversation
|
@xrmx Can I ask you to take a look? Related to the ASGI fix PR |
…emetry-python-contrib into drop-django-1.10-support
|
Thanks for this! The bootstrap_gen script will also need the version boundary change: Line 92 in db66531
And I think the uv-lock file too (this failure). To make that change you can do |
|
@tammy-baylis-swi I think this shoulda fixed it. But the revision changed from 1 to 3 and the majority of uv.lock file changed as a result :(( It's probably because my uv is newer than project's. I was sure though that pre-commit should have prevented that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, I think this is a good change to make. Active support for < 2 ended 8 years ago, and 1.11 stopped getting security updates almost 6 years ago. This will help with the mentioned ASGI instrumentation fix and might also streamline middleware instrumentation: #3723
Maintainers and other approvers will have a look too.
|
@tammy-baylis-swi who should I ask for helping with merging this? |
I've just added the Maintainers group for more reviews, and this PR is on the "PR Digest" board for visibility. @xrmx will probably circle back to this but there are lots of other PRs about, so just keep in mind! |
Description
Drop support for django 1.10 to simplify the implementation of the fix here for ASGI instrumentation
Type of change
Please delete options that are not relevant.
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.