Skip to content

Conversation

@zmievsa
Copy link

@zmievsa zmievsa commented Jan 5, 2026

Description

Drop support for django 1.10 to simplify the implementation of the fix here for ASGI instrumentation

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@zmievsa zmievsa requested a review from a team as a code owner January 5, 2026 10:57
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 5, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

@zmievsa
Copy link
Author

zmievsa commented Jan 5, 2026

@xrmx Can I ask you to take a look? Related to the ASGI fix PR

@tammy-baylis-swi
Copy link
Contributor

Thanks for this!

The bootstrap_gen script will also need the version boundary change:

And I think the uv-lock file too (this failure). To make that change you can do tox -e precommit on your local.

@zmievsa
Copy link
Author

zmievsa commented Jan 6, 2026

@tammy-baylis-swi I think this shoulda fixed it. But the revision changed from 1 to 3 and the majority of uv.lock file changed as a result :((

It's probably because my uv is newer than project's. I was sure though that pre-commit should have prevented that

Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, I think this is a good change to make. Active support for < 2 ended 8 years ago, and 1.11 stopped getting security updates almost 6 years ago. This will help with the mentioned ASGI instrumentation fix and might also streamline middleware instrumentation: #3723

https://endoflife.date/django

Maintainers and other approvers will have a look too.

@zmievsa
Copy link
Author

zmievsa commented Jan 8, 2026

@tammy-baylis-swi who should I ask for helping with merging this?

@tammy-baylis-swi tammy-baylis-swi requested a review from a team January 8, 2026 16:42
@tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi who should I ask for helping with merging this?

I've just added the Maintainers group for more reviews, and this PR is on the "PR Digest" board for visibility. @xrmx will probably circle back to this but there are lots of other PRs about, so just keep in mind!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

2 participants