[WIP] Add Falcon enrich_metric_attributes if Labeler contains custom attributes#4309
Draft
tammy-baylis-swi wants to merge 16 commits intoopen-telemetry:mainfrom
Draft
[WIP] Add Falcon enrich_metric_attributes if Labeler contains custom attributes#4309tammy-baylis-swi wants to merge 16 commits intoopen-telemetry:mainfrom
enrich_metric_attributes if Labeler contains custom attributes#4309tammy-baylis-swi wants to merge 16 commits intoopen-telemetry:mainfrom
Conversation
…er-server-duration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates Falcon instrumentor to use Labeler
enrich_metric_attributesbefore adding/recording each metric, old and new semconv: HTTP server duration, active requests counter. Has no effect if Labeler is not called by instrumented code or custom distro.Depends on
enrich_metric_attributesfor HTTP server duration/request/response metrics #4300Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
tox -e py312-test-instrumentation-falcon-0Example app-side call to add attributes with Labeler:
Example otelcol debug HTTP server duration metrics from instrumentation:
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.