-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disconnect gRPC client stub when shutting down OTLPSpanExporter #4370
base: main
Are you sure you want to change the base?
Conversation
@xmakro Thanks for the PR, please add a CHANGELOG entry. Can this be tested? |
I added the change log. I don't see a good way to test the disconnect, since it is the gRPC channel that gets disconnected, but these channels are not exposed on the gRPC server side api. |
...pentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/exporter.py
Outdated
Show resolved
Hide resolved
@xmakro, do you have time to look into these failures? Or do you mind if I branch and take a stab? |
The checks report a ruff error. I synced this branch to head, updated ruff and ran the pre-commit and cannot reproduce this error. I'm happy if you can fix this by branching.
|
Otherwise the gRPC client will stay connected past the shutdown
Fixes #4429