suppress unnecesary test messages from logs benchmark #4242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: emdneto <[email protected]>
emdneto
changed the title
|
Does it affect numbers? |
@xrmx Yes. I can share the differences for Execution Time Metrics (in milliseconds)
Operational Metrics
|
|
Closing as the benchmark was added to test LoggingHandler so it does makes sense. Maybe can just set propagate to false to suppress the logs while still benchmark the LoggingHandler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have a lot of
test messagesbeing logged in benchmarks that are not necessary to log, and we can suppress them to facilitate seeing the results. Example: https://github.com/open-telemetry/opentelemetry-python/actions/runs/11517939886/job/32063666683