-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ExplicitBucketBoundaries advisory for Histograms #4361
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Any clue on the docs CI error? I would say to add to nitpick_ignore.
Nope, it's really hard for me to understand where this is coming from. Tried using |
Appear to work fine with the flask implementation after updating the create_histogram calls for HTTP_SERVER_REQUEST_DURATION:
|
We can probably use a TypedDict or just add
|
Moved to TypedDict, thanks for the hint! |
3c8b98e
to
181596b
Compare
Description
This adds basic support for the advisory attribute of Instruments and implements ExplicitBucketBoundaries advisory for Histograms.
Fixes #4140
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: