opentelemetry-exporter-otlp-proto-common: permit to serialize null values in logs #4400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzchen
approved these changes
Jan 27, 2025
xrmx
commented
Jan 28, 2025
...xporter-otlp-proto-common/src/opentelemetry/exporter/otlp/proto/common/_internal/__init__.py
Outdated
Show resolved
Hide resolved
…metry/exporter/otlp/proto/common/_internal/__init__.py
lmolkova
reviewed
Jan 28, 2025
...xporter-otlp-proto-common/src/opentelemetry/exporter/otlp/proto/common/_internal/__init__.py
Show resolved
Hide resolved
exporter/opentelemetry-exporter-otlp-proto-common/tests/test_log_encoder.py
Outdated
Show resolved
Hide resolved
aabmass
reviewed
Jan 30, 2025
...xporter-otlp-proto-common/src/opentelemetry/exporter/otlp/proto/common/_internal/__init__.py
Show resolved
Hide resolved
lmolkova
approved these changes
Jan 30, 2025
emdneto
approved these changes
Jan 31, 2025
|
OK I think this is ready to go, @lzchen can you take one more look at my changes? |
lzchen
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes logs encoding to work with body if it is a mapping with null keys.
Fixes #4279
Fixes #4392
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: