-
Notifications
You must be signed in to change notification settings - Fork 717
Make pyright run in standard mode #4425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to get CLA signed to get things merged, so please take a look at the CLA error
7720c96
to
6230592
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Signed-off-by: emdneto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing is, in strict mode, there are a lot of fixes to do even for opentelemetry-api
(124 errors, 0 warnings, 0 informations) which is already fine according to mypy setup. so I'm thinking on the following plan:
- Keep mypy in CI for a while
- Add pyright in standard mode, with a strict list (this PR)
- Fix typing issues from the exclude list in follow-up small PRs
- When the fix list for at least
opentelemetry-api
andopentelemetry-sdk/resources
is done, we remove mypy from CI.
I did some changes to help this get in.
Signed-off-by: emdneto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds a like a plan, thanks!
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
@pierceroberts can you create a tracking issue with the typing issues we are ignoring here so we can fix them later?
|
|
Description
Partially address:
#4404
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: