Fix oltp exporter shutdown race condition #4490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exports can start after the lock is acquired but before the shutdown flag is set, this raises an error if the channel has already been closed. Avoid this race condition by setting the shutdown flag before acquiring the lock.
jomcgi
force-pushed
the
bug-4465/py13-oltp-exporter-error
branch
from
d63bc56 to
ee7e730
Compare
jomcgi
changed the title
xrmx
approved these changes
Mar 26, 2025
5 tasks
|
Closing as this will be resolved by #4511 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exports can start after the lock is acquired but before the shutdown flag is set, this raises an error if the channel has already been closed.
Avoid this race condition by setting the shutdown flag before acquiring the lock.
Fixes #4465
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
tox -e py313-test-opentelemetry-exporter-otlp-proto-grpcDoes This PR Require a Contrib Repo Change?
Checklist: