Add exporter/opentelemetry-exporter-otlp-proto-grpc to the pyright include list. Fix all lint errors in that package.
#4566
+148
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…include list. Fix all lint errors in that package.
|
Not sure why that docs check is failing.. |
You are exporting more stuff and so something must be added to the sphinx ignore list |
|
Aha didn't know about the sphinx ignore list thanks. What do you think of adding |
emdneto
reviewed
May 14, 2025
...pentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/exporter.py
Outdated
Show resolved
Hide resolved
|
BTW I bumped pyright up to ==1.1.400 here to get rid of the warning message asking us to upgrade it... Didn't cause any issues AFAICT... |
emdneto
approved these changes
May 28, 2025
lzchen
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
exporter/opentelemetry-exporter-otlp-proto-grpcto the pyright include list. Fix all lint errors in that package.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests all pass
Does This PR Require a Contrib Repo Change?
Checklist: