Fix max recursion bug by removing logging.log calls in emit #4588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t__.py Co-authored-by: Emídio Neto <[email protected]>
…er test is done. Fix lint issues..
1 task
emdneto
approved these changes
May 16, 2025
aabmass
approved these changes
May 16, 2025
|
I'll just manually resolve the backport in the release branch |
aabmass
added a commit
to aabmass/opentelemetry-python
that referenced
this pull request
May 16, 2025
…emetry#4588) * Fix max recursion bug by removing logging.log calls in emit * Update opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py Co-authored-by: Emídio Neto <[email protected]> * Add changelog * Fix linter * Respond to comments in PR * Remove log line * Fix lint issues * Attach handler to SDK logger instead of root logger and remote it after test is done. Fix lint issues.. * Assert no logs emitted. ADd try/except block for cleanup * Skip test on <python3.10 * Run precommit * Apply suggestions from code review * use try/finally instead of try/except --------- Co-authored-by: Emídio Neto <[email protected]> Co-authored-by: Aaron Abbott <[email protected]>
aabmass
added a commit
that referenced
this pull request
May 16, 2025
…4589) * Fix max recursion bug by removing logging.log calls in emit * Update opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py * Add changelog * Fix linter * Respond to comments in PR * Remove log line * Fix lint issues * Attach handler to SDK logger instead of root logger and remote it after test is done. Fix lint issues.. * Assert no logs emitted. ADd try/except block for cleanup * Skip test on <python3.10 * Run precommit * Apply suggestions from code review * use try/finally instead of try/except --------- Co-authored-by: DylanRussell <[email protected]> Co-authored-by: Emídio Neto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove logging.log calls from
BatchProcessor.emit. Any log calls in that function can get routed back toemitand ultimately result in a maximum recursion depth exceeded exception.fixes #4585
How Has This Been Tested?
Added a unit test to prevent this.
Does This PR Require a Contrib Repo Change?
Checklist: