Remove events
from the API/SDK, an Event
is now a LogRecord
with the EventName
field set
#4651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See open-telemetry/opentelemetry-specification#4045 and open-telemetry/opentelemetry-specification#4319 - the event API and SDK are deprecated in the spec.
The only change made to support events is adding the event name field to the LogRecord. If you want to emit an event you can do so using the logging API/SDK using a LogRecord with the event_name field set. This simplifies the code a bunch and aligns python with the spec and what other languages do.
I have another PR (#4645) out to update the proto version ahead of v1.5 which added event_name to the LogRecord, and to add the event_name field to the LogRecord API/SDK.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests. This change is deleting code only.
Does This PR Require a Contrib Repo Change?
Checklist: