chore(deps): update dependency ruby to v4#1933
Conversation
895190d to
b2e11a0
Compare
arielvalentin
left a comment
There was a problem hiding this comment.
Do not update these
1d58b93 to
d59ad0c
Compare
arielvalentin
left a comment
There was a problem hiding this comment.
Again. Don't upgrade matrix versions
0e5f782 to
52d8d90
Compare
|
@arielvalentin this might actually be good to merge now given it just touches fossa & an example docker compose file. |
.github/workflows/fossa.yml
Outdated
| @@ -18,7 +18,7 @@ jobs: | |||
| - name: Install Ruby 3.4 | |||
There was a problem hiding this comment.
We should remove the version number from here
| uses: ruby/setup-ruby@675dd7ba1b06c8786a1480d89c384f5620a42647 # v1.281.0 | ||
| with: | ||
| ruby-version: 3.4.8 | ||
| ruby-version: 4.0.1 |
There was a problem hiding this comment.
We should avoid using bug fix or patch versions since they aren't always available via setup Ruby
There was a problem hiding this comment.
What I have done in #1955 is that when the workflow is changed the action is run which will identify any issues/incompatibility. Note the setup-Action should be updated prior to updating the ruby.
There was a problem hiding this comment.
@arielvalentin i think we could look to merge this based on https://github.com/ruby/setup-ruby/releases/tag/v1.282.0 showing that 4.0.1 is supported.
I also have #2052 which would detect incompatibilities between ruby & setup-ruby in pr's such as this. Also setup-ruby updates will be raised any weekday regardless of update type and is in the first batch raised per day.
02f2f20 to
4332bd7
Compare
7b2a8d3 to
000693e
Compare
|
Apologies for the delay - I've replied back to renovatebot/renovate#40273 (reply in thread) but it looks like, yes #1933 (comment) is the best course of action and should match here If you use |
|
(once the config is corrected, you'll need to close this PR + rename the PR title - now the PR is open, Renovate won't close it, unless you do) |
76ce7cc to
c527680
Compare
This PR contains the following updates:
3.4.8→4.0.1Release Notes
ruby/ruby (ruby)
v4.0.1: 4.0.1Compare Source
What's Changed
benchmarkis shown when usingbenchmark-ips- Ruby - Ruby Issue Tracking SystemNote: This list is automatically generated by tool/gen-github-release.rb. Because of this, some commits may be missing.
Full Changelog
v4.0.0: 4.0.0See also:
What's Changed
#io_writehook on IO flush by noteflakes · Pull Request #15609--with-ext=when ENABLE_SHARED=yes: ruby/digest.h not found for rubyspec CAPI extensions - Ruby - Ruby Issue Tracking SystemNote: This list is automatically generated by tool/gen-github-release.rb. Because of this, some commits may be missing.
Full Changelog
Configuration
📅 Schedule: Branch creation - "before 8am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.