feat: Add log record exporter interface #1666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaylareopelle
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam and
robbkidd
as code owners
mwear
reviewed
Aug 6, 2024
| @@ -7,6 +7,9 @@ | |||
| module OpenTelemetry | |||
| module SDK | |||
| module Logs | |||
| ExportError = Class.new(OpenTelemetry::Error) | |||
There was a problem hiding this comment.
In order for this to match the convention in traces, this should be a Logs::Export::ExportError (needs to be nested under the Export module).
see:
opentelemetry-ruby/sdk/lib/opentelemetry/sdk/trace/export.rb
Lines 9 to 14 in 92748f2
There was a problem hiding this comment.
Thank you! Fixed in 425ab1c
kaylareopelle
commented
Aug 8, 2024
Comment on lines
+10
to
+11
| # The Export module contains the built-in exporters and log record | ||
| # processors for the OpenTelemetry reference implementation. |
There was a problem hiding this comment.
This more closely matches the description of the Trace Export module.
mwear
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the duck type for the log record exporter.
Spec: https://opentelemetry.io/docs/specs/otel/logs/sdk/#logrecordexporter
Closes: #1487