-
Notifications
You must be signed in to change notification settings - Fork 276
fix: add merge logic for exponential histogram when the temporality cumulative #1869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: add merge logic for exponential histogram when the temporality cumulative #1869
Conversation
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
|
As an end-user what is the result of not having this fix? If we use exponential histograms, are they not accurate? |
|
This pr is for adding merge logic for cumulative aggregation. |
We use Alloy as the collector—how do I know whether it is able to handle histogram merges? I'm trying to understand whether I need this patch in order to use exponential histograms with the Ruby SDK today. |
|
I believe the alloy does merge the exponential histogram bucket (histogram.go) |
kaylareopelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to take another pass, but two small cleanup points in the meantime
metrics_sdk/lib/opentelemetry/sdk/metrics/aggregation/exponential_bucket_histogram.rb
Outdated
Show resolved
Hide resolved
metrics_sdk/lib/opentelemetry/sdk/metrics/aggregation/exponential_bucket_histogram.rb
Outdated
Show resolved
Hide resolved
|
@xuan-cao-swi - Could you send me a link to the Python implementation you used? I'd like to compare the two. |
|
@kaylareopelle - Yes, _merge function and when the merge is required |
Description
Test
Test case are copied from python metrics sdk, and modified based on ruby metrics sdk data structure.