Skip to content

Conversation

@miry
Copy link
Contributor

@miry miry commented Oct 29, 2025

The logger library will be removed from Ruby’s default gems starting with version 3.5.0, so it needs to be declared explicitly as a dependency.

$ grep "require 'logger'" -R .
./api/lib/opentelemetry.rb:require 'logger'
./api/test/opentelemetry/context_test.rb:require 'logger'
./sdk/lib/opentelemetry/sdk/forwarding_logger.rb:require 'logger'
./test_helpers/lib/opentelemetry/test_helpers.rb:require 'logger'

The `logger` library will be removed from Ruby’s default gems starting with version 3.5.0,
so it needs to be declared explicitly as a dependency.
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this, @miry! I'm going to change the conventional commit message in your PR title to to feat so this change kicks off a release.

@kaylareopelle kaylareopelle changed the title chore: add explicit logger dependency to api and sdk gems feat: add explicit logger dependency to api and sdk gems Oct 29, 2025
@kaylareopelle kaylareopelle merged commit 1933d4c into open-telemetry:main Nov 4, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants