Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tonic to 0.10.0 #1252

Closed
wants to merge 0 commits into from
Closed

Update tonic to 0.10.0 #1252

wants to merge 0 commits into from

Conversation

rodoufu
Copy link
Contributor

@rodoufu rodoufu commented Sep 6, 2023

Fixes #

Fixes and issue when using tonic 0.10.0

Changes

Update tonic version to 0.10.0

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 6, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@rodoufu rodoufu closed this Sep 6, 2023
@djc
Copy link
Contributor

djc commented Sep 7, 2023

Why did you close this? Would be nice to have.

@rodoufu
Copy link
Contributor Author

rodoufu commented Sep 7, 2023

Why did you close this? Would be nice to have.

@djc I need to fix all the build issues before opening reopening it.

@TommyCpp
Copy link
Contributor

TommyCpp commented Sep 7, 2023

Feel free to reopen it and mark it as a draft while you are working on the build fix

@djc djc reopened this Oct 10, 2023
@djc
Copy link
Contributor

djc commented Oct 10, 2023

Going to reopen to make sure we don't forget this. (Also note that this doesn't include -stackdriver but probably should.)

@waynexia
Copy link
Contributor

Hi! Thanks for bringing this up. I'm stuck on this as one of my other dependents has to bump tonic's version to 0.10. How could I help on getting this merged?

@getong
Copy link

getong commented Dec 26, 2023

Two month ago, try again?

@rodoufu rodoufu mentioned this pull request Dec 27, 2023
4 tasks
@rodoufu
Copy link
Contributor Author

rodoufu commented Dec 27, 2023

After merging #1457 where the workspace dependencies are described in the workspace manifest will be easier to fix this one an update tonic.

@flokli
Copy link

flokli commented Jan 1, 2024

@rodoufu can you rebase this? There's also #1461 with the same goal, maybe there's some useful context there, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants