test: Add ignored code in test to prove known issue #2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2872 +/- ##
=====================================
Coverage 81.3% 81.3%
=====================================
Files 125 125
Lines 24130 24134 +4
=====================================
+ Hits 19622 19630 +8
+ Misses 4508 4504 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lalitb
reviewed
Mar 31, 2025
| fn on_end(&self, _span: SpanData) { | ||
| // TODO: Accessing Context::current() will panic today and hence commented out. | ||
| // See https://github.com/open-telemetry/opentelemetry-rust/issues/2871 | ||
| // let _c = Context::current(); |
There was a problem hiding this comment.
We can also add an ignored test using a TestSpanProcessor that accesses Context::current() in on_end(), to validate the expected behavior once it's safe.
lalitb
approved these changes
Mar 31, 2025
cijothomas
added a commit
to cijothomas/opentelemetry-rust
that referenced
this pull request
Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To demonstrate the issue #2871
This PR is not investigating/fixing the issue, but rather adding a test to confirm the issue exists.