fix: ignore deferred spans when delegating sampling decision #3209
+38
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagators could leave spans in a deferred state. For example, the following valid set of b3-multi headers does eactly that:
but
ShouldSampleimplementation foropentelemetry_sdk::trace::sampler::Sampleronly checks that the parent span is active.The correct behaviour would be to fall back to delegate sampler when the parent spans has deferred flag set by a propagator.
Changes
Sampler::ParentBasedbranch in theshould_samplemethod now checks is the parent span hasTRACE_FLAG_DEFERREDset and filters all deferred spans.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes