Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify key-value format (issue 4296) #4315

Closed
wants to merge 1 commit into from

Conversation

sparecycles
Copy link

Fixes #4296

The documentation was a little misleading (to me at least) if I focused on this part alone:

... except that additional semi-colon delimited metadata is not supported, i.e.: key1=value1,key2=value2.
as the "i.e.," was illustrating correct/supported usage and not note that immediately preceded it.

Changes

FROM

The OTEL_EXPORTER_OTLP_HEADERS, OTEL_EXPORTER_OTLP_TRACES_HEADERS, OTEL_EXPORTER_OTLP_METRICS_HEADERS, OTEL_EXPORTER_OTLP_LOGS_HEADERS environment variables will contain a list of key value pairs, and these are expected to be represented in a format matching to the W3C Baggage, except that additional semi-colon delimited metadata is not supported, i.e.: key1=value1,key2=value2. All attribute values MUST be considered strings.

TO

The OTEL_EXPORTER_OTLP_HEADERS, OTEL_EXPORTER_OTLP_TRACES_HEADERS, OTEL_EXPORTER_OTLP_METRICS_HEADERS, OTEL_EXPORTER_OTLP_LOGS_HEADERS environment variables will contain a list of key value pairs, and these are expected to be represented in a format matching W3C Baggage i.e., key1=value1,key2=value2. Semi-colon delimited metadata is not supported. All attribute values MUST be considered strings.

(strikethough and bold added here to highlight differences)

@sparecycles sparecycles requested review from a team as code owners December 1, 2024 16:51
Copy link

linux-foundation-easycla bot commented Dec 1, 2024

CLA Not Signed

@@ -165,7 +165,7 @@ release).

### Specifying headers via environment variables

The `OTEL_EXPORTER_OTLP_HEADERS`, `OTEL_EXPORTER_OTLP_TRACES_HEADERS`, `OTEL_EXPORTER_OTLP_METRICS_HEADERS`, `OTEL_EXPORTER_OTLP_LOGS_HEADERS` environment variables will contain a list of key value pairs, and these are expected to be represented in a format matching to the [W3C Baggage](https://www.w3.org/TR/baggage/#header-content), except that additional semi-colon delimited metadata is not supported, i.e.: key1=value1,key2=value2. All attribute values MUST be considered strings.
The `OTEL_EXPORTER_OTLP_HEADERS`, `OTEL_EXPORTER_OTLP_TRACES_HEADERS`, `OTEL_EXPORTER_OTLP_METRICS_HEADERS`, `OTEL_EXPORTER_OTLP_LOGS_HEADERS` environment variables will contain a list of key value pairs, and these are expected to be represented in a format matching [W3C Baggage](https://www.w3.org/TR/baggage/#header-content) i.e., `key1=value1,key2=value2`. Semi-colon delimited metadata is not supported. All attribute values MUST be considered strings.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a link to "Semi-colon delimited metadata", point to https://www.w3.org/TR/baggage/#property.

@MrAlias
Copy link
Contributor

MrAlias commented Dec 2, 2024

Please be sure to sign the CLA so these changes can be evaluated.

@sparecycles
Copy link
Author

Sorry, I don't really have the time/energy to go through the CLA process just to push trivial documentation changes (involves internal company approval processes as well).

Thanks for answering my questions, though!

@sparecycles sparecycles closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page feedback - exporter (delimiters)
4 participants