-
Notifications
You must be signed in to change notification settings - Fork 933
Extend the set of attribute value types #4651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Copilot <[email protected]>
This reverts commit c17aec6.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Martin Costello <[email protected]>
|
We'd like to get this merged today. If there's no further feedback by log sig meeting we'll merge |
| See [this document](attribute-type-mapping.md) to find out how to map values obtained | ||
| outside OpenTelemetry into OpenTelemetry attribute values. | ||
|
|
||
| ### Standard Attribute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link checking is failing because this section has been removed, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/18904968462/job/53961074422
docs/languages/java/api/index.html
hash does not exist --- docs/languages/java/api/index.html -->
/docs/specs/otel/common/#standard-attribute
What should be used as an alternative to common/#standard-attribute? I don't see any mention of standard attributes in the page anymore. Here is an excerpt of the markdown with that link:
### Attributes
[Attributes](https://www.javadoc.io/doc/io.opentelemetry/opentelemetry-api/latest/io/opentelemetry/api/common/Attributes.html)
is a bundle of key value pairs representing the
[standard attribute definition](/docs/specs/otel/common/#standard-attribute).
`Attributes` are a recurring concept in the OpenTelemetry API:/cc @open-telemetry/docs-approvers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's track this via:
Changes
AnyValuetype supporting complex data structures (empty value, byte arrays, heterogeneous arrays and maps).AnyValuetype.Extend attribute types
Prior-art (this PR guides towards this): #4636
Prototype: open-telemetry/opentelemetry-go#6809
Follows #4614
Related to #4602
Related proto PR: open-telemetry/opentelemetry-proto#707
https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/4485-extending-attributes-to-support-complex-values.md#how describes how languages should add support for new attribute value types.
Closes #4460 (no longer needed - feature is removed)
OTEP changes
Notice that this PR has changed the strategy for https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/4485-extending-attributes-to-support-complex-values.md#api from:
to simply:
This is the agreement up to this point: #4651 (comment)
The other change in the OTEP is because of #4651 (comment).
Attribute limit updates
Towards #4487
This also proposes minimal and non-breaking additions for the attribute limits: https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/4485-extending-attributes-to-support-complex-values.md#attribute-limits.
The proposal for attribute count limit is proposed because of #4651 (comment).
The proposal for attribute value length limit seems the most logical to me.
Comments to be addressed as followups
I am going to create issues to be created after this is PR merged: