-
Notifications
You must be signed in to change notification settings - Fork 933
Deprecate Zipkin exporter #4715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
f81bd0c
c2a913b
e053411
097163a
3e3cd00
e2b9726
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -334,8 +334,8 @@ Disclaimer: Declarative configuration is currently in Development status - work | |||||||
| | **[Zipkin](specification/trace/sdk_exporters/zipkin.md)** | Optional | Go | Java | JS | Python | Ruby | Erlang | PHP | Rust | C++ | .NET | Swift | | ||||||||
| | Zipkin V1 JSON | X | - | + | | + | - | - | - | - | - | - | - | | ||||||||
| | Zipkin V1 Thrift | X | - | + | | [-][py1174] | - | - | - | - | - | - | - | | ||||||||
| | Zipkin V2 JSON | * | + | + | | + | + | - | + | + | + | + | + | | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Should we remove the following? opentelemetry-specification/spec-compliance-matrix.md Lines 11 to 13 in d5cfbdf
|
||||||||
| | Zipkin V2 Protobuf | * | - | + | | + | - | + | - | - | - | - | - | | ||||||||
| | Zipkin V2 JSON | X | + | + | | + | + | - | + | + | + | + | + | | ||||||||
| | Zipkin V2 Protobuf | X | - | + | | + | - | + | - | - | - | - | - | | ||||||||
| | Service name mapping | | + | + | + | + | + | + | + | + | + | + | + | | ||||||||
| | SpanKind mapping | | + | + | + | + | + | + | + | + | + | + | + | | ||||||||
| | InstrumentationLibrary mapping | | + | + | - | + | + | - | + | + | + | + | + | | ||||||||
|
|
||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -4,7 +4,14 @@ linkTitle: Zipkin | |||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||
| # OpenTelemetry to Zipkin Transformation | ||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||
| **Status**: [Stable](../../document-status.md) | ||||||||||||||||||||||||||||||||||||||||||||||||
| **Status**: [Deprecated](../../document-status.md) | ||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||
| _Note: This document remains here for backwards compatibility and | ||||||||||||||||||||||||||||||||||||||||||||||||
| will be removed in a future version. SDKs MAY include Zipkin exporters, | ||||||||||||||||||||||||||||||||||||||||||||||||
| but Zipkin exporter is not required. | ||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||
| Users may export to Zipkin using [zipkin exporter](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/zipkinexporter) collector component or [zipkin-otel](https://github.com/openzipkin-contrib/zipkin-otel) | ||||||||||||||||||||||||||||||||||||||||||||||||
| Zipkin server module_ | ||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+9
to
+14
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not properly formatted. Maybe
Suggested change
or
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||
| This document defines the transformation between OpenTelemetry and Zipkin Spans. | ||||||||||||||||||||||||||||||||||||||||||||||||
| The generic transformation [rules specified here](../../common/mapping-to-non-otlp.md) also apply. If a | ||||||||||||||||||||||||||||||||||||||||||||||||
|
|
@@ -69,7 +76,7 @@ not work properly. OpenTelemetry doesn't provide this consistency guarantee. | |||||||||||||||||||||||||||||||||||||||||||||||
| Exporter may chose to override the value for service name based on a local root | ||||||||||||||||||||||||||||||||||||||||||||||||
| span to improve Zipkin user experience. | ||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||
| *Note*, the attribute `service.namespace` MUST NOT be used for the Zipkin | ||||||||||||||||||||||||||||||||||||||||||||||||
| _Note_, the attribute `service.namespace` MUST NOT be used for the Zipkin | ||||||||||||||||||||||||||||||||||||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not seen such way of adding notes anywhere else. Maybe just (or revert)
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||||||||
| service name and should be sent as a Zipkin tag. | ||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||
| ### SpanKind | ||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.