[configuration] Clarify that the boolean value environment variable guidance is not applicable to other configuration interfaces #4723
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uidance is not applicable to other configuration interfaces
mx-psi
force-pushed
the
mx-psi/not-applicable
branch
from
a7872e5 to
2e2811e
Compare
dashpole
reviewed
Nov 5, 2025
Contributor
dashpole
left a comment
dashpole
left a comment
There was a problem hiding this comment.
I agree with the intent of the change, but it seems like it will create more confusion to me, as it implies (but doesn't specify) that the rest of the document applies to declarative configuration. I would prefer splitting the env var spec into a "common" config spec (excluding the boolean spec), and the env var spec with the current bool spec + anything else that only applies to env vars.
Member
Author
|
Makes sense, I will wait for a few more days and apply the suggested change if there is no dissent :) |
github-merge-queue bot
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Nov 7, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number if applicable --> Marks `configoptional.AddEnabledField` as beta. I have verified that it would work correctly for cookies configuration and made a PoC for keepalives (I will push a PR for it after this PR has been merged). I spent some time updating open-telemetry/opentelemetry-specification/issues/4344 and filed open-telemetry/opentelemetry-specification/pull/4723 as a way to explicitly state that the guidance only applies to environment variables. The issue remains unresolved, but given the current usages of `enabled` (see open-telemetry/opentelemetry-specification#4344 (comment)) I don't see a reason to not go forward with this. #### Link to tracking issue Updates #14021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #4344
Changes
Clarifies that environment variable guidance regarding boolean values is not applicable to other configuration interfaces. This does not explicitly state what the guidance should be in other cases.