-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Integrations promotion, docs, and guidance #3221
Comments
Thanks for raising this @cartersocha A few comments:
Right now the page for integrations only holds oss integrations, so as it looks like only the recently open source nginx module would meet that criteria. I think we should open that up. Note that the whole vendor, integrations, adopters is still in flux and needs a major rework. I have an idea in my head how to make things better but I need some time to write this down and maybe make a proposal via a PR. Although, if nobody objects I think we can already add those 1P integrations to the current page.
There is guidance for that already: https://opentelemetry.io/docs/concepts/instrumentation/libraries We also started to improve the manual instrumentation guidelines which are crucial for that, see
We also have an explicit pointer via the "Devs" getting started: https://opentelemetry.io/docs/getting-started/dev/ So the focus should be on the "clear" part, how can we make this more visible to people that want to do integrations? There is probably some cross linking we can do, to improve that. But key is to have per-language documentation for manual instrumentation improved as this is the crucial part for people wanting to do the actual work.
I am happy to adopt ideas for that.
Happy to take those blog posts in, although we still need to be cautious around commercial offerings. We have been very reluctant to accept anything that's non OSS for our blog.
We can create such an entrypoint, but at the end this is something that the language SIGs have to carry, so they need to provide the bandwidth to help with that. |
Thanks for the detailed comments and context. I do strongly believe we need to re-visit our open source / vendor split for integrations / promotion. I understand our default inclination to OSS but as OTel eats the world we'll be handicapping the project significantly by insisting on OSS only. If IBM creates a first party non-OSS integration for mainframes that's a significant milestone for them and the community that should be spotlighted / celebrated |
I do not disagree, the way how it is today is just how things grew over time, of course we can change that. My bigger concern is that the way how we present the different adopters is sub-optimal, since what we have as adopters right now are "end users" (which is again confusing as a term), integrations is only some OSS projects that use OpenTelemetry and a vendor is an endless list of companies that may or may not provide an observability backend that is OTLP-compliant. So the first step is re-thinking that representation of the OpenTelemetry ecosystem and create a more meaningful structure, for example:
Each one could be split in sub-categories again. |
See a related comment: open-telemetry/opentelemetry-java-instrumentation#9337 (comment) We are currently working on a how-to guide for native instrumentation (including all the best practices, things to consider and learnings we gained from instrumenting the Elasticsearch clients natively) and were planning to publish that either as an OTel blog post or as part of the OTel docs. I think that would also help with the topic raised here. @cartersocha @svrnm WDYT about that?
+1 on extending the integrations to non-open-source projects as well. Since the community would benefit from integrations in those projects as well. cc @estolfo |
That would be great! We always prefer docs over blog posts, but starting with a blog post makes it easier to promote the topic and we still can work from there to turn it into docs. But we can make that decision when the content is ready :-) |
Sounds great @AlexanderWert! I spoke with Morgan from the GC who followed up with communications. We should be good to add non-OSS integrations and vendor integration blogs to the website with the normal community caveats I’m planning on working with Nginx, Tyk, and VMWare to open blog PRs or other content additions |
@cartersocha thanks! Can you share some links to the integrations for Nginx, Tyk & VMware already? Besides OSS vs non-OSS there is also something we should discuss if we want to change (see #3182 as well): right now we focus on "native integrations", aka opentelemtry is built-in to the library, application. Cerbos but maybe also nginx are good examples for first-part but non-native integrations since you need to load an additional module (=instrumentation library) to make them work. I think we should have a preference for native still and highlight them, but it also adds value if a first-party integration is accomplished by the party themselves. |
Also, we (Cisco) provide some first-party integrations with OpenTelemetry as well :-) |
@svrnm I provided most of the links above already. All 3 are about to be released but aren't yet. Unfortunately Nginx and VMWare don't have an easy demo. But Tyk has this really nice docker up example - https://github.com/SonjaChevre/api-observability-opentelemetry S/o @SonjaChevre for that 😎 |
I can add the relevant company contacts if necessary here too. Mostly coordinating on CNCF slack |
lol ... I totally missed that. Thanks. |
If there is a slack channel already where you discuss this please share the link here so folks can join in. I think what we need is a clear plan on what we want to do exactly to promote those integrations: having them in the "Integrations" page is step 1 and easy to implement since we only need to update our list. If we want to do more (blog posts etc) we should figure out details first. |
Is there a preferred community channel I can add them to? #otel-comms? |
#otel-comms should work just fine, yes |
please take a look at #3221 Note that I didn't include Tyk & VMWare, because both links indicate that OpenTelemetry is planned but not yet existing. Maybe that's a misunderstanding from my site, so please let me know. I restructured the document in a why that it
|
Hi! I’m a product manager from Tyk. We released yesterday the latest version of our open source API Gateway (5.2) which includes native support for OpenTelemetry distributed tracing. happy to be included into the list of integration. Let me know if you have any questions! |
Thanks @SonjaChevre, I updated the PR to include Tyk API Gateway as well. Since I skimmed over your docs, a minor comment on the "Common HTTP Span Attributes": the ones listed in your documentation are not up-to-date with some of the most recent spec changes (http.method => http.request.method, http.status_code => http.response.status_code, http.schema => url.scheme http.url => url.full) |
Thanks @svrnm, really appreciate this feedback! I will pass this info to the team. |
I think we accomplished some/most of the topics. there is more work that needs to be done, but we should put that into new issues. |
As OpenTelemetry continues to gain traction we need to ensure that services and platforms are able to easily integrate with OpenTelemetry, have straightforward guidance, and that the integrations are properly spotlighted. Given that many services are already choosing to adopt OpenTelemetry on their own we have a great opportunity to supercharge this movement.
The current integrations page is missing at least 4 current or upcoming substantial 1P integrations.
There has also been general user frustration with the lack of documentation around adding OpenTelemetry into a library you own.
If we overhaul our integration experience to better serve 1P integrations, we can accelerate project adoption while reducing our need to develop and maintain bespoke components. With an eye towards the upcoming KubeCon (November 6th) I propose we:
The text was updated successfully, but these errors were encountered: