Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integrations #3278

Merged
merged 13 commits into from
Sep 21, 2023
Merged

Update integrations #3278

merged 13 commits into from
Sep 21, 2023

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Sep 15, 2023

This is going to address some of #3221 requirements, cc @cartersocha

Signed-off-by: svrnm <[email protected]>
@svrnm svrnm requested a review from a team September 15, 2023 15:03
Signed-off-by: svrnm <[email protected]>
Copy link
Contributor

@cartersocha cartersocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome start

@cartersocha
Copy link
Contributor

We should add integrations as a link on the homepage too - https://opentelemetry.io/

@cartersocha
Copy link
Contributor

Not directly related to this PR but we may need to rethink the registry, adopters, and integrations pages a bit. Loose overlap that maybe could be combined?

@svrnm
Copy link
Member Author

svrnm commented Sep 19, 2023

Not directly related to this PR but we may need to rethink the registry, adopters, and integrations pages a bit. Loose overlap that maybe could be combined?

Yes, we need to rethink a lot of that. for example if you look into the vendors there are 90% backends, but there are also at least two vendors of pipelines and probably some other non-backends, which may count as integrations or "something else"

@svrnm
Copy link
Member Author

svrnm commented Sep 19, 2023

We should add integrations as a link on the homepage too - opentelemetry.io

not with this PR.

Copy link
Member

@mhausenblas mhausenblas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some suggestions inline

content/en/docs/what-is-opentelemetry.md Outdated Show resolved Hide resolved
content/en/ecosystem/integrations.md Outdated Show resolved Hide resolved
content/en/ecosystem/integrations.md Outdated Show resolved Hide resolved
content/en/ecosystem/integrations.md Outdated Show resolved Hide resolved
content/en/ecosystem/integrations.md Outdated Show resolved Hide resolved
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions to streamline a little bit and reduce marketing overtones. (Although perhaps that's intended?)

content/en/ecosystem/integrations.md Outdated Show resolved Hide resolved
content/en/ecosystem/integrations.md Outdated Show resolved Hide resolved
content/en/ecosystem/integrations.md Outdated Show resolved Hide resolved
@svrnm
Copy link
Member Author

svrnm commented Sep 20, 2023

thank you @mhausenblas & @theletterf, I have applied most of your suggestions :-)

Signed-off-by: svrnm <[email protected]>
Copy link
Member

@arminru arminru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Signed-off-by: svrnm <[email protected]>
@svrnm
Copy link
Member Author

svrnm commented Sep 20, 2023

5b46734 includes a few additional words for the documentation index:

https://deploy-preview-3278--opentelemetry.netlify.app/docs/

@cartersocha
Copy link
Contributor

Not directly related to this PR but we may need to rethink the registry, adopters, and integrations pages a bit. Loose overlap that maybe could be combined?

Yes, we need to rethink a lot of that. for example if you look into the vendors there are 90% backends, but there are also at least two vendors of pipelines and probably some other non-backends, which may count as integrations or "something else"

Would this be a topic for the communications sig or another one? Happy to join and brainstorm or talk through potential re-orgs

@svrnm
Copy link
Member Author

svrnm commented Sep 20, 2023

Not directly related to this PR but we may need to rethink the registry, adopters, and integrations pages a bit. Loose overlap that maybe could be combined?

Yes, we need to rethink a lot of that. for example if you look into the vendors there are 90% backends, but there are also at least two vendors of pipelines and probably some other non-backends, which may count as integrations or "something else"

Would this be a topic for the communications sig or another one? Happy to join and brainstorm or talk through potential re-orgs

Sig Comms, yes. We have had our share of discussions on this topic already, if you review some old issues (like #2178) you will get some more context. This PR is probably not the best place to discuss this. Feel free to raise a new meta issue, we can link to existing issues from there and have a consolidated discussion. I may have the one or the other opinion as well ;-)

@svrnm svrnm merged commit 08c4b50 into open-telemetry:main Sep 21, 2023
12 checks passed
@svrnm svrnm deleted the update-integrations branch September 21, 2023 13:19
@cartersocha
Copy link
Contributor

Small follow up PR - #3306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants