-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add dapr workflow blog post #8698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add dapr workflow blog post #8698
Conversation
Sync upstream changes
Signed-off-by: Kasper Borg Nissen <[email protected]>
tiffany76
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the post! I've left a few comments.
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
Signed-off-by: Kasper Borg Nissen <[email protected]>
|
Thank. you for the quick response, @tiffany76 🙏 All comments have been addressed. Do you have any guidance on what date I can set? |
| author: >- | ||
| [Mauricio "Salaboy" Salatino](https://github.com/salaboy) (Diagrid), | ||
| [Kasper Borg Nissen](https://github.com/kaspernissen) (Dash0) | ||
| cSpell:ignore: Salatino Salaboy durabletask Diagrid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| cSpell:ignore: Salatino Salaboy durabletask Diagrid | |
| cSpell:ignore: dapr dapr's diagrid durabletask kasper nissen salatino salaboy |
|
/fix:format |
|
❌ |
|
Hi @kaspernissen - we can get this published today, but it doesn't look like you've given maintainers permission to work on your branch, so you'll have to clear up the CI issues yourself. I've added the spelling and linter fixes as comments. You can also run Next time around, make sure to give maintainers permission to work on your branch. Thanks! |
Signed-off-by: Kasper Borg Nissen <[email protected]>
Signed-off-by: Kasper Borg Nissen <[email protected]>
|
@tiffany76 yeah, sorry about that. I hope all issues are resolve now 🙏 |
Signed-off-by: Kasper Borg Nissen <[email protected]>
|
Hi @kaspernissen - you'll want to commit the two suggestions I made last week. They will resolve the spelling and text linter issues. Thanks. |
|
/fix:dict |
|
I'm pretty sure those changes already is in there. I just landed in Thailand where I will be on vacation until the Jan 19. Will have to wait until I get back 😕 |
|
❌ |
Co-authored-by: Tiffany Hrabusa <[email protected]>
|
looks good to me from a first quick read, looking forward to have this :-) |
|
can we double check that the dapr link here is up-to-date https://opentelemetry.io/ecosystem/integrations/ ? |
Co-authored-by: Tiffany Hrabusa <[email protected]>
contribution guidelines,
including the First-time contributing? note.
the
Generative AI Contribution Policy.
This PR submits the blog post mentioned in #8697 for review.