Add span rendering template and clean up span briefs and notes #1505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
commented
Oct 22, 2024
lmolkova
commented
Oct 22, 2024
lmolkova
force-pushed
the
add-span-template
branch
2 times, most recently
from
484e395 to
319067b
Compare
lmolkova
changed the title
trask
reviewed
Apr 7, 2025
Member
trask
left a comment
trask
left a comment
There was a problem hiding this comment.
sorry, just realized all of my suggestions are on the (now) auto-generated markdown files
anyways, this is great, thanks!
lmolkova
force-pushed
the
add-span-template
branch
2 times, most recently
from
53c4007 to
5e3c8fd
Compare
trask
approved these changes
Apr 8, 2025
github-project-automation
bot
moved this from Untriaged
to Needs More Approval
in Semantic Conventions Triage
joaopgrassi
approved these changes
Apr 9, 2025
lmolkova
force-pushed
the
add-span-template
branch
from
5356deb to
4a90e2e
Compare
lmolkova
moved this from Needs More Approval
to Ready to be Merged
in Semantic Conventions Triage
github-project-automation
bot
moved this from Ready to be Merged
to Needs More Approval
in Semantic Conventions Triage
lmolkova
pushed a commit
to lmolkova/semantic-conventions
that referenced
this pull request
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1086
This change moves span descriptions, naming, status, and kind guidance to yaml and makes some cosmetic changes to the wording without changing anything substantial.
While span definition is still not completely structured, it allows to at least provide this info to codegen. It also helps to stay more consistent documenting all span properties in MD.
[chore]schema-next.yaml updated with changes to existing conventions.