-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the concept of reference attributes to the spec #1521
base: main
Are you sure you want to change the base?
Conversation
Given the existence of the use of |
Here are some possible naming alternatives to
Any other thoughts? Any opinions on what is best? |
I've updated the pull request to use |
…rences proposal to avoid a conflict with existing uses of '*.ref.*'.
I think Should there be some tooling to make sure we don't accidentally define anything |
@@ -98,6 +98,15 @@ Recommendations on using attributes vs. body fields: | |||
* The _fields_ are unique to the named event (`event.name`) and different events | |||
may use the same _field_ name to represent different data, due to the unique | |||
nature of the event. | |||
* The _fields_ SHOULD NOT use the `*.blob_ref.*` name, except when applying the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIt: You can provide a policy to enforce this in the /policies
directory. Would like to see this happen after this naming and feature is approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I'm happy to either add this enforcement in a separate PR or to add to the existing PR. Would it be better to do that separately or in a single PR?
Fixes #1428
Changes
Adds the concept of "reference attributes" / "reference fields" to the specification.
Merge requirement checklist