-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in schemas for messaging attribute changes #1595
Fix typo in schemas for messaging attribute changes #1595
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
it seems we should not update old schemas - semantic-conventions/CONTRIBUTING.md Lines 140 to 141 in c5093dd
I'd like to stop producing/updating these files manually - #1596. Curious what brought your attention to these files, @JamieDanielson ? Do you happen to use them in any way? |
We were updating our semantic conventions package in JS and wanted to make sure we captured the breaking changes since we also recently updated our build script. I just happened to notice the typo in the 0.28 schema file and put up a PR to fix it. We don't use this attribute anywhere as far as I can tell. |
Changes
While reviewing recent semantic convention changes, I noticed these typos for messaging changes.
Merge requirement checklist
[chore]