Skip to content

Conversation

@XSAM
Copy link
Member

@XSAM XSAM commented Mar 26, 2025

Fixes #1504

Changes

Rename rpc.grpc.status_code to rpc.grpc.response.status_code

Merge requirement checklist

@XSAM XSAM marked this pull request as ready for review March 26, 2025 18:09
@XSAM XSAM requested review from a team as code owners March 26, 2025 18:09
@trask
Copy link
Member

trask commented Mar 26, 2025

thanks @XSAM!

I think RPC is one we may want to consider as "de-facto stable" and introduce language like we have done for HTTP, Database, Messaging and System semantic conventions (e.g. see the Warning on https://github.com/open-telemetry/semantic-conventions/blob/main/docs/database/README.md)

It is better for users to get all the breaking changes in a single major version bump instead of lots of small breaking changes over time.

We may also want to wait to kick off these changes until we kick off a semconv RPC stability SIG that is dedicated to working through it.

@maryliag
Copy link
Contributor

considering the comment from Trask about trying to make big changes all at once, should the change to seconds be done on the same PR? It's not the same metrics, but is on the same "group", since is rpc

@trask
Copy link
Member

trask commented Mar 27, 2025

I think we will want to kick off an RPC semconv stabilization effort. I'm interested in helping that effort once database semconv is stabilized.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 12, 2025
@github-actions
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Rename rpc.grpc.status_code to grpc.response.status_code

3 participants