Skip to content

Conversation

@thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented Jul 5, 2025

Progresses #2467

Changes

In a couple of scenarios spans either had 2 name definitions or 2 span kinds. Each of these were for different use cases, hence these have been split into 2 spans.

Reason for the change

This is a blocker for moving to code generated span registries as a span can only have 1 type, hence should be separate definitions.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

@thompson-tomo thompson-tomo requested review from a team as code owners July 5, 2025 03:48
@thompson-tomo thompson-tomo requested review from a team as code owners July 5, 2025 03:48
@thompson-tomo thompson-tomo force-pushed the chore/#2467_splitMultiUseSpans branch 2 times, most recently from 917c014 to ad4efe1 Compare July 5, 2025 04:06
@thompson-tomo thompson-tomo changed the title Split multi use spans in 2 distinct #2467 Split multi use spans in to 2 distinct spans #2467 Jul 5, 2025
@thompson-tomo thompson-tomo changed the title Split multi use spans in to 2 distinct spans #2467 Split multi use gen-ai spans in to 2 distinct spans #2467 Jul 26, 2025
@thompson-tomo thompson-tomo force-pushed the chore/#2467_splitMultiUseSpans branch from ad4efe1 to 1c1b0f6 Compare July 26, 2025 02:19
@thompson-tomo thompson-tomo force-pushed the chore/#2467_splitMultiUseSpans branch from 1c1b0f6 to 78941e5 Compare July 26, 2025 02:23
@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented Jul 26, 2025

This pr has been split to only include the gen-ai part. @open-telemetry/semconv-genai-approvers can you review

Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe that splitting spans by kind improves end user or instrumentation author experience. Now we duplicate huge span tables and the only difference between them is the kind.

Moreover, we know for a fact that client/internal is frequently a preference - e.g. Spring AI uses internal kind for external model calls - spring-projects/spring-ai#1174, more context #1315

@github-project-automation github-project-automation bot moved this from Untriaged to Blocked in Semantic Conventions Triage Jul 29, 2025
@thompson-tomo
Copy link
Contributor Author

So i have fixed the issue introduced by rebasing as identified by @gyliu513 and the internal span now no longer has the server attributes with the logic being if you know that you are talking to a sever then you aren't internal. Is there any other attributes which only apply when using a server based gen-ai model? For instance are usage tokens still applicable?

@lmolkova i am aware of the ambiguity around span king usage etc and believe that is addressed by using the phrase Should rather than must. I think this scenario is different as the documentation is clearly talking about 2 different kinds of activities, hence splitting them and now removing the non applicable server attributes. If there is others happy to move them to create a bigger difference in definitions.

@thompson-tomo thompson-tomo force-pushed the chore/#2467_splitMultiUseSpans branch from 23347fe to 11e3420 Compare August 3, 2025 06:00
@lmolkova
Copy link
Member

lmolkova commented Sep 2, 2025

I still don't understand which problem this PR is trying to solve and how is it solved by introducing embedded inference span in addition to inference and embeddings. I'm going to close it.

@lmolkova lmolkova closed this Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants