fix: ensure version file has precedence over default#163
Merged
Conversation
Toolo
commented
Jan 29, 2026
| # Default to node 20 but use the .node-version file if it exists in the consumer repo | ||
| node-version: "24" | ||
| node-version-file: .node-version | ||
| node-version: ${{ steps.node-version.outputs.version }} |
Contributor
Author
There was a problem hiding this comment.
The only downside of this approach is that renovatebot won't be able to pick this up for automated node version bumps
Member
There was a problem hiding this comment.
We can probably do it with a regex https://docs.renovatebot.com/modules/manager/regex/#regular-expression-capture-groups + tweaking the file
AmarLassTuro
approved these changes
Jan 29, 2026
antoninmorvan
approved these changes
Jan 29, 2026
antoninmorvan
left a comment
antoninmorvan
left a comment
There was a problem hiding this comment.
👍 . Strange that this error didn't occurred before 🤔
tagoro9
approved these changes
Jan 29, 2026
| # Default to node 20 but use the .node-version file if it exists in the consumer repo | ||
| node-version: "24" | ||
| node-version-file: .node-version | ||
| node-version: ${{ steps.node-version.outputs.version }} |
Member
There was a problem hiding this comment.
We can probably do it with a regex https://docs.renovatebot.com/modules/manager/regex/#regular-expression-capture-groups + tweaking the file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The inline docs used to indicate that
node-version-filewould have priority overnode-versionbut it wasn't true:node-versionalways has precedence. This PR modifies the action to match the expectation.From actions/setup-node README:
Changes
🚀 PR created with fotingo