-
Notifications
You must be signed in to change notification settings - Fork 3
chore(deps): update python docker tag to v3.12.3 #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5577ae5 to
0dda691
Compare
0dda691 to
9162f80
Compare
345ca25 to
6e69037
Compare
6e69037 to
efe5179
Compare
efe5179 to
0312905
Compare
5a4dcf1 to
74ff644
Compare
74ff644 to
444ddc4
Compare
444ddc4 to
6119c00
Compare
action.yaml
Outdated
| uses: pre-commit/[email protected] | ||
| with: | ||
| extra_args: ${{ env.PRE_COMMIT_ARGS }} | ||
| run: | | ||
| pip install pre-commit | ||
| pip freeze --local | ||
| shell: bash | ||
| - run: pre-commit run --show-diff-on-failure --color=always ${{ inputs.extra_args }} | ||
| shell: bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@armand-sauzay I tried this change here, since updating the python version was not working using the pre-commit action. Let me know if this looks good to you!
For now I had to manually reference my branch here to test things https://github.com/open-turo/actions-gha/compare/f/use_new_action_pre_commit?expand=1
I think ideally we should use the python version of the consumer repo if there is one (or allow to specify it). What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree - that should work (and ideally as you say using the python version of the consumer repo would be even better). pip freeze --local is probably optional but fine to keep for debug purposes
It's very similar to what the pre-commit/action does (with the cache that they use to speed up workflows).
I think using cache (also since unused caches get deleted if unused since 7+ days) could be another low hanging fruit if we can bare the cost of gha caches.
action.yaml
Outdated
| uses: pre-commit/[email protected] | ||
| with: | ||
| extra_args: ${{ env.PRE_COMMIT_ARGS }} | ||
| run: | | ||
| pip install pre-commit | ||
| pip freeze --local | ||
| shell: bash | ||
| - run: pre-commit run --show-diff-on-failure --color=always ${{ inputs.extra_args }} | ||
| shell: bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree - that should work (and ideally as you say using the python version of the consumer repo would be even better). pip freeze --local is probably optional but fine to keep for debug purposes
It's very similar to what the pre-commit/action does (with the cache that they use to speed up workflows).
I think using cache (also since unused caches get deleted if unused since 7+ days) could be another low hanging fruit if we can bare the cost of gha caches.
d013514 to
e5d56e9
Compare
f092584 to
f732083
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
armandsauzay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
| @@ -1 +1 @@ | |||
| 3.10.4 | |||
| 3.12.2 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could probably update this to 3.12.4 since that seems to be the global version in packer?
It fails with newer python versions
f732083 to
1db71a8
Compare
Release notes previewBelow is a preview of the release notes if your PR gets merged. 3.2.1 (2025-07-25)Bug Fixes
Miscellaneous
|
This PR contains the following updates:
3.10.4->3.12.3Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.