Add support for at-code coding system in addition to id-code coding system. #16
Add support for at-code coding system in addition to id-code coding system. #16sebastian-iancu merged 30 commits intomasterfrom
Conversation
- added a new code specification for openEHR with at-codes - added at-coded examples in ADL section - reworked texts where it references id-codes to include at-codes (SPECAM-90)
…examples (SPECAM-90) Co-authored-by: Ian McNicoll <[email protected]>
…intro and ADL2.4 changes (SPECAM-90) Co-authored-by: Joost Holslag <[email protected]>
…ing nd cross-reference (SPECAM-90)
|
@bostjanl-better Figure 5 in AOM2 should probably be updated. It lists (only) ID codes as node ids. https://specifications.openehr.org/releases/UML/latest/index.html#Diagrams___18_1_83e026d_1423307491544_806168_4397 |
|
“ The new coding system also carries original id-codes in its archetypes to preserve the original ADL2 codes.” |
|
“ Value_code_leader: String = "at" is not present in aom2.definitions for at coded archetype. Maybe it would help migrating and forward compatibility if we keep this as is from the aom2.definitions for id coded archetypes. |
|
Should be put a not on Root_code_regex_pattern: String = "^at0000(.1)*$" |
|
“The changes in release 2 of the ADL/AOM formalism are designed to make the formalism more computable with respect to terminology, and enable more rigorous validation and flattening operations.” |
Co-authored-by: Joost Holslag <[email protected]>
Co-authored-by: Joost Holslag <[email protected]>
Co-authored-by: Joost Holslag <[email protected]>
…rchetypes to preserve the original ADL2 codes.” from aom2
I think it is clear as is, I would not add anything there - might make it more confusing... |
…tarts with zero and id-code numbering with one
|
Release of the following adl2.4 spec depends on: openEHR/specifications-BASE#14 |
|
@bostjanl-better are you able to add rendered html? Otherwise maybe @sebastian-iancu or @wolandscat |
…se actual 'development' variant (not the 'latest')
ee15112 to
1514e73
Compare
sebastian-iancu
left a comment
There was a problem hiding this comment.
changes requested
| a|Regex used to define the legal numeric part of any archetype code. Corresponds to the simple pattern of dotted numbers, as used in typical multi-level numbering schemes. | ||
|
|
||
| h|*1..1* | ||
| |*Root_code_regex_pattern*: `String{nbsp}={nbsp}"^at0000(\.1)*$"` |
There was a problem hiding this comment.
@joostholslag
discuss how to handle at-coded vs id-coded tables under https://specifications.openehr.org/releases/AM/development/AOM2.html#_adl_code_definitions_class considering backwards compatibility
There was a problem hiding this comment.
I would suggest to just keep all in the same class to keep backwards compatibility. The regex for the root node would then simply accept either id1(.1)* or at0000(.1)*. Also in Archie we are just planning to let the validator simply check if all id-codes are either at-codes or id-codes.
Add support for at-code coding system in addition to id-code coding system. Make the at-code coding system a requirement for openEHR RM compliant implementations.
(SPECAM-90)
TODO: add rendered html
Preview of new docs: