Skip to content

refactor : Migrate savings account summary fragment to compose #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

itsPronay
Copy link
Contributor

@itsPronay itsPronay commented Jul 13, 2024

Fixes JIRA

xml (before) compose (after)
image image
Screencast_07_13_2024_09.10.40_PM.webm
  • Apply the MifosStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@itsPronay itsPronay changed the title refactor : Savings account summary fragment to compose refactor : Migrate savings account summary fragment to compose Jul 13, 2024
@therajanmaurya
Copy link
Member

Toolbar title font size is not right, please fit it and let me know, why API is not working

backup

backup

b

cleanUp

fix

wrap-up

fix currency symbol

fix toolbar size
@itsPronay
Copy link
Contributor Author

Toolbar title font size is not right, please fit it and let me know, why API is not working

@therajanmaurya I am not sure about the exact reason why it is failing but for Every single yellow (other then BEN KIKO's) and blue colored savings screen we're getting Failed to fetch error. I checked the fragment code, we were getting the same error in the fragment screen also.

client - Ben kiko
image

@therajanmaurya therajanmaurya merged commit 426301c into openMF:master Jul 13, 2024
5 checks passed
@itsPronay itsPronay deleted the savingsSummary branch July 13, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants