Skip to content

[2656] : refactor: Sync Surveys Dialog Compose #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

akashmeruva9
Copy link
Contributor

@akashmeruva9 akashmeruva9 commented Jul 21, 2024

Fixes #2161
Jira Task : link

WhatsApp.Video.2024-08-04.at.16.01.12_99830677.mp4
  • Apply the MifosStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@therajanmaurya
Copy link
Member

What is full dialog appear in background before showing sync dialog?

@akashmeruva9
Copy link
Contributor Author

What is full dialog appear in background before showing sync dialog?

Sir this dialog should be called from a Compose Screen, but since @Aditya-gupta99 is still working on the compose migration of the settings Activity, I called this from the previous Dialog Fragment. That's y we can see the background appear.

@therajanmaurya
Copy link
Member

I merged his PR, make the changes and let me know so I can review and merge your PR as well.

@akashmeruva9
Copy link
Contributor Author

I merged his PR, make the changes and let me know so I can review and merge your PR as well.

Ok sir, will try to make the changes

…pose' into refactor_sync_survey_dialog_compose
@akashmeruva9
Copy link
Contributor Author

What is full dialog appear in background before showing sync dialog?

I merged his PR, make the changes and let me know so I can review and merge your PR as well.

Just now confirmed with @Aditya-gupta99, he is still working on the PR and the PR is nnot mergesd !

@therajanmaurya therajanmaurya merged commit a2f9acf into openMF:master Aug 5, 2024
5 checks passed
@akashmeruva9 akashmeruva9 changed the title refactor: Sync Surveys Dialog Compose [2656] : refactor: Sync Surveys Dialog Compose Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor : Sync Surveys Dialog Compose
2 participants